Skip to content

Conversation

@Aarebecca
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Aarebecca, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with worker script path resolution by removing the usage of import.meta.url, which can have limited support or unexpected behavior in certain environments. The core change involves a more robust and compatible approach to determine the script's location using DOM APIs, ensuring that worker scripts are correctly loaded regardless of the module system or browser context. This change improves the overall stability and reach of the library.

Highlights

  • Worker Script Path Resolution: The mechanism for resolving the worker script path has been significantly refactored to remove reliance on import.meta.url.
  • Compatibility Improvement: The resolveWorkerPath method now uses document.currentScript and iterates through script tags to determine the base URL, enhancing compatibility across different JavaScript environments.
  • Package Version Update: The package version has been incremented from 2.0.0-beta.1 to 2.0.0-beta.2.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the worker path resolution logic to remove the dependency on import.meta. The new approach uses document.currentScript and heuristics based on script tag sources, which is a reasonable alternative for environments where import.meta is not available. However, I've identified a potential issue in the fallback logic for discovering the script URL that could lead to incorrect worker paths. My review includes a specific suggestion to make this logic more robust by removing the brittle fallback.

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.00%. Comparing base (6cec35f) to head (7c8a6a5).

Files with missing lines Patch % Lines
src/runtime/supervisor.ts 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v5     #287      +/-   ##
==========================================
- Coverage   86.12%   86.00%   -0.12%     
==========================================
  Files          77       77              
  Lines        5938     5946       +8     
  Branches     1440     1444       +4     
==========================================
  Hits         5114     5114              
- Misses        823      831       +8     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Aarebecca Aarebecca merged commit 54e3ff6 into v5 Jan 22, 2026
2 checks passed
@Aarebecca Aarebecca deleted the fix/import-meta branch January 22, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants