Open
Conversation
Author
|
Any chance you could take a look at this @pkoscik ? |
pkoscik
requested changes
Sep 19, 2025
Member
pkoscik
left a comment
There was a problem hiding this comment.
Hello @bennetleins! Thanks for your contribution.
There seems to be an issue in the way interrupt connections are handled for buttons.
Using this (Nucleo F446ZE) Devicetree file and dts2repl from your PR results in the following snippet:
...
gpioc: GPIOPort.STM32_GPIOPort @ sysbus <0x40020800, +0x400>
userbutton: Miscellaneous.Button @ gpioc 0xd
invert: true
gpioc:
13 -> userbutton@0
...
This is incorrect: the interrupts are connected in reverse (sink to source). Instead, it should generate the following snippet:
...
gpioc: GPIOPort.STM32_GPIOPort @ sysbus <0x40020800, +0x400>
userbutton: Miscellaneous.Button @ gpioc 0xd
invert: true
userbutton:
-> gpioc@13
...
For reference PTAL at a GPIO description for a similar Nucleo board in the Renode tree.
Author
|
I just changed the code to fix the issue with the interrupt connections. If I run the code on the nucleo hello_world I now get this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only LEDs are detected and added automatically. This commit adds the capabilities for Buttons as well.