Add raw completions server mode#61
Open
Dango233 wants to merge 1 commit intoantirez:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds an opt-in
--raw-completionsmode fords4-server.When enabled,
/v1/completionstreats the requestpromptas an already-rendered model prompt and continues it directly, instead of wrapping it in the built-in DS4 chat template. The default behavior is unchanged.Why
This aligns ds4's opt-in completions behavior with llama.cpp-style raw completions, where the client owns prompt rendering and the server only performs continuation.
That is useful for clients and experiments that provide their own model-specific templates, including text-completion/instruct frontends such as SillyTavern, KoboldAI/KoboldCpp-style clients, and custom completion clients that send rendered prompts directly.
Notes
POST /v1/chat/completionsis unchanged./v1/completionsbehavior is unchanged unless--raw-completionsis passed.Testing
make ds4-server ds4_test./ds4_test --server./ds4-server --help | rg -n "raw-completions|completions"