Open
Conversation
Collaborator
tusharmath
commented
Mar 26, 2026
- refactor(config): adopt forge_config in domain and services
- refactor(auth): remove auth logic and config fields
crates/forge_repo/src/forge_repo.rs
Outdated
| )); | ||
|
|
||
| let config_repository = Arc::new(ForgeConfigRepository::new()); | ||
| let config_repository = Arc::new(ForgeConfigRepository::new(infra.clone())); |
Contributor
There was a problem hiding this comment.
Compilation Error: Parameter mismatch
This line calls ForgeConfigRepository::new(infra.clone()), passing an infra parameter. However, the new() method shown in forge_repo/src/app_config.rs (line 122) has the signature:
pub fn new() -> Self {
Self { cache: Arc::new(Mutex::new(None)) }
}The method does not accept any parameters, but this call is passing infra.clone(). This will fail to compile with an error like "this function takes 0 arguments but 1 argument was supplied".
Fix: Either update the ForgeConfigRepository::new() signature to accept the infra parameter:
pub fn new(infra: Arc<F>) -> Self {
Self { cache: Arc::new(Mutex::new(None)), infra }
}Or remove the parameter from this call if it's not needed:
let config_repository = Arc::new(ForgeConfigRepository::new());
Suggested change
| let config_repository = Arc::new(ForgeConfigRepository::new(infra.clone())); | |
| let config_repository = Arc::new(ForgeConfigRepository::new()); |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.