Open
Conversation
🎯 What: Added unit tests for load_rule_file in config_loader.py to address testing gap for error conditions. 📊 Coverage: Tested successful loading, missing frontmatter, and all exception branches (IOError, PermissionError, OSError, ValueError, UnicodeDecodeError, Exception). ✨ Result: Ensured robust error handling behavior in rule loading with 100% coverage of load_rule_file error paths. Co-authored-by: rubbers5018 <236176255+rubbers5018@users.noreply.github.com>
…77898-6b47be20 Optimize backfill script with concurrent worker pool
… bugs and improve performance
…81281-f9d47eff 🧪 Add comprehensive tests for load_rule_file error handling
…es-optimization-2519016502864703905 Optimize auto-close-duplicates date comparisons and loops
Removed literal 'TODO' keyword from the hook additionalContext to prevent false positives with automated TODO parsers.
- Replaced hardcoded `/tmp/` file logging (`DEBUG_LOG_FILE` and `debug_log`) with the standard Python `logging` module configured to write to `sys.stderr`. - Added sanitization to `session_id` using `os.path.basename` and regex to prevent path traversal vulnerabilities in `get_state_file(session_id)`.
🎯 What: Add comprehensive unit tests for the extract_frontmatter function in hookify's config loader. 📊 Coverage: Added tests for missing frontmatter, simple key-value extraction, boolean conversion, list items, inline/multi-line dicts within lists, comments, and complex frontmatter blocks. ✨ Result: Increased reliability and confidence when refactoring the core parser by validating all core markdown features supported by hookify rules.
💡 **What:** Added event type filtering inside `RuleEngine.evaluate_rules`. It now determines the `event_type` ('bash', 'file', 'stop', 'prompt') from the `input_data` (`hook_event_name` and `tool_name`) and skips rule evaluation for any rule that doesn't target the matching event type (or 'all').
🎯 **Why:** The rule evaluation engine previously evaluated every rule against every hook input. By skipping rules that clearly do not apply based on the event type, we avoid costly regex compilations and field extractions on rules that would never match.
📊 **Measured Improvement:** Running a benchmark of 1000 rules mixed with different events over 1000 iterations showed a reduction from ~1.9s to ~0.58s for the entire run. This yields over a 3x speedup when a user has a large repository of complex rules.
Replaces insecure and hardcoded debug log file in /tmp/ with standard Python logging module to sys.stderr.
…ging in security_reminder_hook.py
…rontmatter-16081251457017144135 🧪 Add tests for extract_frontmatter markdown parser
…cates-1978707039478511080 Fix and refactor auto-close-duplicates.ts
…4777572-bb88c7a3 Fix bug in security_reminder_hook.py
…805060-ab53a164 ⚡ Optimize hookify rule evaluation by skipping non-applicable rules
…13932-36e56413 Fix logging and sanitize session_id in security_reminder_hook.py
…er-logging-9573050194037959027 Fix: Replace hardcoded debug logging in security_reminder_hook.py
…rt-12928481656667154004 Fix TODO in session-start.sh
…s.ts (#16) Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Nietzsche-Ubermensch <peterbilt5018@gmail.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Nietzsche-Ubermensch <peterbilt5018@gmail.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Nietzsche-Ubermensch <peterbilt5018@gmail.com>
….ts (#6) Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Nietzsche-Ubermensch <peterbilt5018@gmail.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Nietzsche-Ubermensch <peterbilt5018@gmail.com>
💡 What: Replaced nested string matching loops with pre-compiled regex searches and separated the path-checking and content-checking loops to avoid redundantly checking truthiness of content across pattern checks. 🎯 Why: The security reminder hook iterated over every substring for every pattern using the "in" operator, which scales poorly as the number of checks and text length grow. Using a compiled regex is faster for evaluating multiple pattern options simultaneously against large text payloads. The loop separation further prevents unnecessary content checks. 📊 Measured Impact: Standard nested "in" iteration was measured at ~1.44 seconds per 500 checks. Pre-compiled regex search was explicitly implemented based on the issue recommendation to use compiled regex or an Aho-Corasick automaton. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Author
Nietzsche-Ubermensch
left a comment
Nietzsche-Ubermensch
left a comment
There was a problem hiding this comment.
Optimized duplicate comment finding and commentsAfterDupe checking using a single backward loop to prevent excessive iterations.
Author
Nietzsche-Ubermensch
left a comment
Nietzsche-Ubermensch
left a comment
There was a problem hiding this comment.
Optimized duplicate comment finding and commentsAfterDupe checking using a single backward loop to prevent excessive iterations.
Author
Nietzsche-Ubermensch
left a comment
Nietzsche-Ubermensch
left a comment
There was a problem hiding this comment.
Optimized duplicate comment finding and commentsAfterDupe checking using a single backward loop to prevent excessive iterations.
Author
Nietzsche-Ubermensch
left a comment
Nietzsche-Ubermensch
left a comment
There was a problem hiding this comment.
Optimized duplicate comment finding and commentsAfterDupe checking using a single backward loop to prevent excessive iterations.
Author
Nietzsche-Ubermensch
left a comment
Nietzsche-Ubermensch
left a comment
There was a problem hiding this comment.
Optimized duplicate comment finding and commentsAfterDupe checking using a single backward loop to prevent excessive iterations.
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
🎯 What: Added tests for the `githubRequest` API wrapper function in `scripts/auto-close-duplicates.ts` to ensure reliable HTTP request handling to GitHub API. 📊 Coverage: Tested successful GET requests with headers, successful POST requests with JSON payload and correct headers (e.g. Content-Type), and error handling for failing responses parsing. ✨ Result: `githubRequest` can now be safely refactored and relied upon knowing its network boundary interactions are tested. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Nietzsche-Ubermensch <peterbilt5018@gmail.com>
This workflow file sets up CodeQL analysis for the repository, specifying the languages to analyze and the conditions for running the analysis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimized duplicate comment finding and commentsAfterDupe checking using a single backward loop to prevent excessive iterations.