Skip to content

Listing 8.13 - Incorrect Implementation #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ITHelpDec wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Listing 8.13 - Incorrect Implementation #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dd352c
complete `join_threads`struct
ITHelpDec Jul 4, 2023
7005688
necessary `else` statement
ITHelpDec Jul 4, 2023
6961ccb
Remote unused variable
ITHelpDec Jul 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions listings/listing_8.13.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,17 @@
#include <thread>
#include <vector>

struct join_threads
{
join_threads(std::vector<std::thread>&)
{}
class join_threads {
public:
explicit join_threads(std::vector<std::thread> &threads) : threads_(threads) { }

~join_threads()
{
for (auto &t : threads_)
if (t.joinable()) { t.join(); }
}
private:
std::vector<std::thread> &threads_;
};


Expand Down Expand Up @@ -74,6 +81,10 @@ void parallel_partial_sum(Iterator first,Iterator last)
{
ith_element=buffer[i];
}
else
{
buffer[i] = ith_element;
}
b.done_waiting();
}
};
Expand All @@ -88,7 +99,6 @@ void parallel_partial_sum(Iterator first,Iterator last)
std::vector<std::thread> threads(length-1);
join_threads joiner(threads);

Iterator block_start=first;
for(unsigned long i=0;i<(length-1);++i)
{
threads[i]=std::thread(process_element(),first,last,
Expand Down