-
Notifications
You must be signed in to change notification settings - Fork 21
workflows: use zip/unzip to keep execution permission #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
.github/workflows/release.yml
Outdated
|
|
||
| - name: Extract Binaries | ||
| run: | | ||
| for f in engine_binaries/*.zip; do unzip $f -d engine_binaries; done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Engine extraction overwrites files and breaks expected paths
Even if the glob pattern were fixed, extracting all engine zips with -d engine_binaries would put all three platforms' dist/ and node_modules/ directly in engine_binaries/, causing them to overwrite each other. Additionally, the code at line 441 expects files at engine_binaries/${artifact_subdir}/dist/$engine_bin, but the extraction produces engine_binaries/dist/$engine_bin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
Hello, we have tested the changes, currently only yasa file has added the execution permission, the others(uast) have not
You can make a try using tar! |
Loss of execution permission of uast* binaries are caused by YASA-UAST binary release I think. In fzf, single binary is released in a zip/tar.gz to keep permission. |

Use zip/unzip to keep execution permission when uploading and downloading artifacts.
The modification is not tested locally because I failed to setup github runner docker container through act. The required space for the github runner is large.
Fixes #96.
Note
Focuses on preserving execute permissions across jobs by zipping artifacts and unzipping where needed.
download_uast_binaries: addchmod +x, zipuast_binariesand uploaduast-binaries.zipinstead of a folderresolve_uast_versions: downloaduast-binariesartifact andunzipbefore deploying todeps/build_engine: packagedist+node_modulesintoengine-<target>.zipand upload the zippackage_release: download engine artifacts withmerge-multiple, unzip allengine-*.zipanduast-binaries.zipbefore packaging platform bundlesWritten by Cursor Bugbot for commit b846f14. This will update automatically on new commits. Configure here.