Skip to content

fix(tui): ensure arrow keys work for question selection #7709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zerone0x wants to merge 1 commit into
base: dev
Choose a base branch
from
+14 −0
Open

fix(tui): ensure arrow keys work for question selection #7709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/opencode/src/cli/cmd/tui/routes/session/question.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,21 @@ export function QuestionPrompt(props: { request: QuestionRequest }) {
const dialog = useDialog()

useKeyboard((evt) => {
// Guard: ensure we have valid question data
const currentQuestion = question()
if (!currentQuestion && !confirm()) return

// When editing "Other" textarea
if (store.editing && !confirm()) {
if (evt.name === "escape") {
evt.preventDefault()
evt.stopPropagation()
setStore("editing", false)
return
}
if (evt.name === "return") {
evt.preventDefault()
evt.stopPropagation()
const text = textarea?.plainText?.trim() ?? ""
const prev = store.custom[store.tab]

Expand Down Expand Up @@ -149,13 +155,15 @@ export function QuestionPrompt(props: { request: QuestionRequest }) {

if (evt.name === "left" || evt.name === "h") {
evt.preventDefault()
evt.stopPropagation()
const next = (store.tab - 1 + tabs()) % tabs()
setStore("tab", next)
setStore("selected", 0)
}

if (evt.name === "right" || evt.name === "l") {
evt.preventDefault()
evt.stopPropagation()
const next = (store.tab + 1) % tabs()
setStore("tab", next)
setStore("selected", 0)
Expand All @@ -164,10 +172,12 @@ export function QuestionPrompt(props: { request: QuestionRequest }) {
if (confirm()) {
if (evt.name === "return") {
evt.preventDefault()
evt.stopPropagation()
submit()
}
if (evt.name === "escape" || keybind.match("app_exit", evt)) {
evt.preventDefault()
evt.stopPropagation()
reject()
}
} else {
Expand All @@ -176,16 +186,19 @@ export function QuestionPrompt(props: { request: QuestionRequest }) {

if (evt.name === "up" || evt.name === "k") {
evt.preventDefault()
evt.stopPropagation()
setStore("selected", (store.selected - 1 + total) % total)
}

if (evt.name === "down" || evt.name === "j") {
evt.preventDefault()
evt.stopPropagation()
setStore("selected", (store.selected + 1) % total)
}

if (evt.name === "return") {
evt.preventDefault()
evt.stopPropagation()
if (other()) {
if (!multi()) {
setStore("editing", true)
Expand All @@ -210,6 +223,7 @@ export function QuestionPrompt(props: { request: QuestionRequest }) {

if (evt.name === "escape" || keybind.match("app_exit", evt)) {
evt.preventDefault()
evt.stopPropagation()
reject()
}
}
Expand Down