fix(tui): show home sessions in global project#29582
Open
cagedbird043 wants to merge 1 commit into
Open
Conversation
When the TUI is opened from the user's home directory, the global project can report the worktree as the filesystem root. The session list then filters by path like home/user, which excludes older home sessions stored with an empty path.\n\nTreat the global home directory as project scope so /sessions includes both legacy empty-path home sessions and newer home sessions.\n\nConstraint: Session filtering is controlled by the TUI sync query, not by session storage.\nRejected: Refreshing the dialog browse order | local verification showed the session never reached dialog options because the query path was wrong.\nConfidence: high\nScope-risk: narrow\nTested: bun typecheck from packages/opencode\nTested: bunx oxlint packages/opencode/src/cli/cmd/tui/context/sync.tsx (pre-existing warnings only)\nTested: git diff --check\nTested: bun run build --single --skip-install --skip-embed-web-ui\nTested: local TUI verification from /home/cagedbird showed the missing home session again
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: fix(tui): scope session list to current worktree directory (#29026) This PR appears related because it also deals with scoping sessions to worktree directories in the TUI, which is closely related to the session filtering logic being fixed in PR #29582. Both PRs address how sessions are filtered and displayed based on their path/worktree context. |
Author
|
Note for reviewers: #29026 is related to session/worktree scoping, but it does not cover this global-home case. This PR fixes the TUI producing a home-relative path filter for the global home project, which excludes older home sessions stored with an empty path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29581
Type of change
What does this PR do?
Fixes
/sessionsfrom the global home project hiding older home sessions.When opencode is opened from the user's home directory, the global project can report the worktree as
/. The TUI then filters sessions by a path likehome/user, excluding older home sessions stored with an empty path.This treats the global home directory as project scope, so both empty-path home sessions and newer home-path sessions are shown.
How did you verify your code works?
cd packages/opencode && bun typecheckbunx oxlint packages/opencode/src/cli/cmd/tui/context/sync.tsx(existing warnings only)git diff --checkcd packages/opencode && bun run build --single --skip-install --skip-embed-web-ui/home/cagedbirdthat the missing home session reappeared in/sessions.Screenshots / recordings
Not applicable. This changes the session query used by the TUI; local verification was done in the TUI.
Checklist