fix(server): honor workspace header in routing#29481
Closed
YOMXXX wants to merge 1 commit into
Closed
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
However, this is not a duplicate — it's addressing a separate but related routing concern. The current PR (#29481) focuses on honoring the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29468
Type of change
What does this PR do?
Workspace routing selected a workspace only from the
workspacequery parameter. The generated SDK keepsx-opencode-workspaceas a header for non-GET requests such asPOST /session/:id/prompt_async, so Web could load/list agents in the selected workspace on GET routes but submit prompts in a different instance context on POST routes.This makes workspace routing also read
x-opencode-workspace, matching the existingx-opencode-directoryfallback. Local workspace POST requests now route to the selected workspace target instead of the fallback directory.How did you verify your code works?
PATH="$HOME/.bun/bin:$PATH" bun test test/server/httpapi-workspace-routing.test.ts -t "routes local workspace requests from workspace header"PATH="$HOME/.bun/bin:$PATH" bun test test/server/httpapi-workspace-routing.test.tsPATH="$HOME/.bun/bin:$PATH" bun test test/server/httpapi-promptasync-context.test.tsPATH="$HOME/.bun/bin:$PATH" bun test test/server/httpapi-query-schema-drift.test.tsPATH="$HOME/.bun/bin:$PATH" bun typecheckfrompackages/opencode.PATH="$HOME/.bun/bin:$PATH" bun x prettier --check src/server/routes/instance/httpapi/middleware/workspace-routing.ts test/server/httpapi-workspace-routing.test.ts.git diff --check.PATH="$HOME/.bun/bin:$PATH" .husky/pre-pushcurrently fails in unrelated@opencode-ai/console-supporttypecheck because local dependencies/generated console-core modules are missing (@solidjs/*,solid-js/jsx-runtime,vite,@opencode-ai/console-core/*). The touchedopencodepackage typecheck completed separately and passed.Screenshots / recordings
N/A - server routing fix.
Checklist