fix(core): handle JSON parse failure gracefully in models-dev (fixes #29366)#29404
Open
levgiorg wants to merge 1 commit into
Open
fix(core): handle JSON parse failure gracefully in models-dev (fixes #29366)#29404levgiorg wants to merge 1 commit into
levgiorg wants to merge 1 commit into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found a potential duplicate: PR #29385: fix(core): add fallback for JSON parse errors in models-dev This PR appears to address the same issue as PR #29404 - handling JSON parse failures in the models-dev file. Both PRs are tackling the same problem of gracefully handling parse errors (likely from network failures returning HTML instead of JSON) and providing fallback behavior. |
|
This PR seems to be missing the part that prints out the error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29366
Type of change
What does this PR do?
Wrap JSON.parse() in models-dev.ts in a try/catch so that network failures (e.g., HTML returned instead of JSON from blocked connections) don't crash opencode on startup. Returns
{}on parse failure.How did you verify your code works?
Checklist