Skip to content

fix(web): persist docs English locale selection#29381

Closed
SpencerJung wants to merge 1 commit into
anomalyco:devfrom
SpencerJung:fix/29326-language-picker
Closed

fix(web): persist docs English locale selection#29381
SpencerJung wants to merge 1 commit into
anomalyco:devfrom
SpencerJung:fix/29326-language-picker

Conversation

@SpencerJung
Copy link
Copy Markdown

@SpencerJung SpencerJung commented May 26, 2026

Summary

  • persist oc_locale=en when docs navigation selects the default English locale via an unprefixed docs URL
  • keep locale alias redirects in one helper and add focused tests for English selection, alias handling, and cookie parsing

Closes #29326

Verification

  • lsp_diagnostics: packages/web/src/middleware.ts
  • lsp_diagnostics: packages/web/src/middleware-locale.ts
  • lsp_diagnostics: packages/web/src/middleware-locale.test.ts
  • bun test --cwd packages/web src/middleware-locale.test.ts
  • bun run --cwd packages/web build

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label May 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions
Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential duplicate found:

This PR has the same exact title as the current PR (#29381) and appears to address the same issue (persisting English locale selection in the docs). This is likely a duplicate that needs to be addressed—either this PR should be closed or PR #29351 should be reviewed if it was already merged/closed.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label May 26, 2026
@github-actions github-actions Bot closed this May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Language picker in docs does nothing

1 participant