fix(shell): use byte length for preview truncation (fixes #29291)#29372
Open
levgiorg wants to merge 1 commit into
Open
fix(shell): use byte length for preview truncation (fixes #29291)#29372levgiorg wants to merge 1 commit into
levgiorg wants to merge 1 commit into
Conversation
Previously preview() used text.length (UTF-16 code units) which caused incorrect truncation for multi-byte characters. Changed to use Buffer.byteLength() matching the tail() function pattern. Fixes anomalyco#29291
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate PRs FoundPR #29297:
PR #29288:
Both of these PRs appear to be addressing the same issue as PR #29372 (the current PR) — fixing shell tool preview truncation to use byte length instead of character/UTF-16 code unit length. You may want to review these existing PRs to determine if they've already been merged or closed, and whether your PR is redundant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29291
Type of change
What does this PR do?
Fix shell tool preview truncation which used UTF-16 code unit length instead of byte length, causing incorrect truncation for multi-byte characters.
How did you verify your code works?
Checklist