fix(shell): case-insensitive pwsh env var lookup (fixes #29290)#29371
Open
levgiorg wants to merge 1 commit into
Open
fix(shell): case-insensitive pwsh env var lookup (fixes #29290)#29371levgiorg wants to merge 1 commit into
levgiorg wants to merge 1 commit into
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate:
Why they're likely related: Both PRs address the same issue (#29290) regarding case-insensitive pwsh environment variable lookup. PR #29287 appears to be an earlier or related attempt to fix the same problem. You should verify whether #29287 was already merged, closed, or if this PR (#29371) supersedes it. |
Previously envValue() returned process.env[key] directly on non-Windows platforms, failing for mixed-case $env: references in pwsh. Now performs case-insensitive lookup on all platforms. Fixes anomalyco#29290
levgiorg
force-pushed
the
fix/issue-29290-pwsh-env-case
branch
from
b611196 to
eb37f90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #29290
Type of change
What does this PR do?
Fix pwsh
$env:expansion to use case-insensitive env var lookup on all platforms, not just Windows.How did you verify your code works?
Checklist