fix: handle invalid maxOutputTokens value (0 or undefined)#22016
Open
Jedeiah wants to merge 1 commit intoanomalyco:devfrom
Open
fix: handle invalid maxOutputTokens value (0 or undefined)#22016Jedeiah wants to merge 1 commit intoanomalyco:devfrom
Jedeiah wants to merge 1 commit intoanomalyco:devfrom
Conversation
Fixes anomalyco#21858 Fixes anomalyco#21522 - Returns OUTPUT_TOKEN_MAX when model.limit.output is 0, undefined, or negative - Adds unit tests for maxOutputTokens function
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21858
Closes #21522
Type of change
What does this PR do?
Fixes maxOutputTokens returning 0 when model.limit.output is 0, undefined, or negative. Returns OUTPUT_TOKEN_MAX (32000) as fallback when model output limit is invalid.
When plugins pass maxOutputTokens=0 via chat.params hook, OpenCode 1.4.0+ requires >= 1, which causes "maxOutputTokens must be >= 1" error for local providers like Ollama.
How did you verify your code works?
Screenshots / recordings
N/A (not a UI change)
Checklist