fix: guard gpt-5 reasoningSummary for azure#21951
Closed
Mayhem50 wants to merge 1 commit intoanomalyco:devfrom
Closed
fix: guard gpt-5 reasoningSummary for azure#21951Mayhem50 wants to merge 1 commit intoanomalyco:devfrom
Mayhem50 wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
Related PRs (same problem space, different approaches):
|
Author
|
Closing this as a duplicate of the follow-up refactor PR, which supersedes this narrower fix: #21955 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21237
Type of change
What does this PR do?
This fixes an inconsistency in
ProviderTransform.optionsforgpt-5models.textVerbositywas already guarded for Azure, butreasoningSummarywas still being injected for Azuregpt-5models. That made the transform logic inconsistent and could send unsupported options to Azure.This change applies the same Azure guard to
reasoningSummaryand adds coverage for both the OpenAI and Azure paths intransform.test.ts.How did you verify your code works?
gpt-5.2bun test test/provider/transform.test.tsbun typecheckScreenshots / recordings
Not applicable.
Checklist