fix: preserve prompt draft across permission prompts#21950
Open
Mayhem50 wants to merge 1 commit intoanomalyco:devfrom
Open
fix: preserve prompt draft across permission prompts#21950Mayhem50 wants to merge 1 commit intoanomalyco:devfrom
Mayhem50 wants to merge 1 commit intoanomalyco:devfrom
Conversation
Author
|
The The job hangs for 30 minutes after All other jobs ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #21320
Type of change
What does this PR do?
This fixes a TUI regression where text typed into the main session prompt could be lost when a permission prompt temporarily replaced the prompt UI.
The root cause was that the session prompt is unmounted while a permission request is shown, but the in-progress draft only lived inside the prompt component state. This change preserves the current prompt state when the prompt unmounts and restores it when the prompt mounts again. It also includes the prompt mode in
PromptRef.currentso shell-mode drafts are restored correctly.How did you verify your code works?
permission.askedandpermission.replied, and verifies that the prompt draft is restored after the permission prompt is dismissed.bun test test/cli/tui/session-permission-draft.test.tsxbun typecheckScreenshots / recordings
Not included. This is a TUI-only change covered by an automated regression test.
Checklist