Fix inconsistent credit consumption in chat #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in credit consumption for chat messages where subsequent user messages in multi-turn conversations were incorrectly flagged as agent calls, preventing proper credit deduction. The fix changes the isAgentCall detection logic to examine only the last message in the conversation history instead of checking all messages.
Changes:
- Modified
isAgentCalldetection to check only the last message in thebody.messagesarray instead of usingsome()to check all messages - Added defensive check to ensure messages array is not empty before accessing the last element
- Aligned the logic with the existing pattern used for
body.inputhandling
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refactor `isAgentCall` logic to check only the last message in the history rather than any message. This prevents valid user messages from being incorrectly flagged as agent calls due to previous assistant history, ensuring proper credit consumption for multi-turn conversations. Fixes #9
sr-tream
force-pushed
the
fix-credits-consume
branch
from
081ed39 to
ab3c902
Compare
|
+1 on this, merge please |
Contributor
|
ill release later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
isAgentCalllogic to check only the last message in the history rather than any message. This prevents valid user messages from being incorrectly flagged as agent calls due to previous assistant history, ensuring proper credit consumption for multi-turn conversations.Fixes #9