Skip to content

Conversation

@anod
Copy link
Owner

@anod anod commented Oct 25, 2025

No description provided.

@anod anod requested a review from Copilot October 25, 2025 17:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the action handling system by replacing screen-specific action interfaces with a common ScreenCommonAction approach, consolidating action types and improving code reusability across different screens.

Key changes:

  • Replaces custom action interfaces (WishListAction, WatchListAction, SearchViewAction, etc.) with ScreenCommonAction
  • Introduces onScreenCommonAction() helper function for standardized action handling
  • Consolidates action creation through helper functions (startActivityAction, showToastAction, showSnackbarAction)

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib Subproject commit update
app/build.gradle.kts Version code increment
WishListViewModel.kt Removed custom WishListAction interface, migrated to ScreenCommonAction
WishListScreen.kt Simplified action handling using onScreenCommonAction helper
WatchListStateViewModel.kt Removed custom WatchListAction interface and local action helper functions
MainScreen.kt Replaced manual action handling with onScreenCommonAction helper
ShowSnackbarAction.kt New file defining PlainShowSnackbarData and showSnackbarAction helper
UserLogScreen.kt Added required navigateTo parameter to onScreenCommonAction
TagWatchListScreen.kt Simplified action handling using onScreenCommonAction
TagSnackbar.kt Updated to use TagSnackbarAppInfo data class
SchedulesHistoryScreen.kt Added navigateTo parameter and fixed layout modifier
SearchViewModel.kt Removed SearchViewAction interface, refactored event handling
SearchResultsScreen.kt Simplified action handling with onScreenCommonAction
SceneNavKey.kt Added ScreenCommonNavKey extension and asNavKey conversion
InstalledListViewModel.kt Removed custom action interface and simplified back press handling
InstalledListScreen.kt Added navigateTo parameter support
HistoryListViewModel.kt Removed HistoryListAction interface, migrated to ScreenCommonAction
HistoryListScreen.kt Added navigateTo parameter and simplified action handling
DetailsViewModel.kt Updated ShowTagSnackbar to use TagSnackbarAppInfo wrapper
DetailsPanel.kt Updated to access app through TagSnackbarAppInfo wrapper
AccountSelectionRequest.kt Added AccountSelectionDialogData and showAccountSelectionAction
AppWatcherActivity.kt Added navigateTo parameters to screen scenes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@anod anod merged commit 125aff8 into master Oct 25, 2025
1 of 2 checks passed
@anod anod deleted the dev/fix-actions branch October 25, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants