CI test for 16kb and non-16kb page alignment

[Haz3-jolt]

Purpose / Description

Updates GitHub workflow matrix to extend to 16kb page alignment.

Fixes

• Fixes CI should test 16kb and non-16kb page alignment in libraries, packaging, and emulator #16917

Approach

• Attempts to verify the APK with 16KB page alignment
• First tries with build-tools v35.0.0, then falls back to v34.0.0 if needed
• Provides clear success/failure messages

How Has This Been Tested?

Passes CI on fork

Learning (optional, can help others)

Refered to 16KB page alignment docs

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[Arthur-Milchior]

I don't understand enough to tell anything else than that we should add a note about the original author of the new file, sorry

[Haz3-jolt]

@mikehardy
I tried to verify page size with:

      - name: Verify Page Size
        if: matrix.target == 'google_apis_ps16k'
        run: |
          PAGE_SIZE=$(adb shell getconf PAGE_SIZE)
          echo "Page size: $PAGE_SIZE"
          if [ "$PAGE_SIZE" != "16384" ]; then
            echo "Error: Expected page size of 16384, got $PAGE_SIZE"
            exit 1
          fi

But when I noticed it wasn't running in the tests, I realised we can't run adb shell getconf PAGE_SIZE, without an emulator. Is it okay to not include it? I've tried adding it to the Emulator script in here. But It wasn't working.

Is there some other way to test it?

[david-allison]

Executes a Google script. Looks fine to me

[mikehardy]

Sorry this sat so long when you were trying to close an issue I logged myself!

I think all of the ideas and the main work here are great. My comments need to be addressed but I think (hope ?) they're all easy modifications on your core work here, just to future proof it

[mikehardy]

closer still - but did realize that we're not actually executing tests against the google_apis_ps16k emulator target

[mikehardy]

Fantastic - approved, pending upstream PR merge+release and this change here

Suggested change

	target: google_apis
	target: google_apis_ps16k

• Pending fix: allow google_apis_ps16k as a valid target ReactiveCircus/android-emulator-runner#440

[Haz3-jolt]

Yep I have amended the commit already, waiting for the release to do a force push!

[mikehardy]

had a review comment on that PR I just had time to address now, hopefully will release soon - maintainer there is collaborating fine and that change is needed of course

[mikehardy]

Hasn't been released yet, but temporarily depending on this commit hash for the android-emulator-runner package should work, the PR is merged now ReactiveCircus/android-emulator-runner@66283c0

[mikehardy]

Upstream emulator runner finally released with my PR, should be good to go

[mikehardy]

Dangit. My PR was apparently inadequate, the emulator type of 16kb is now going through but there is some missing piece translating that to the create create avd command

  /usr/bin/sh -c \echo no | avdmanager create avd --force -n test --abi 'google_apis_ps16k/x86_64' --package 'system-images;android-36;google_apis_ps16k;x86_64'  --sdcard '100M'
  Loading local repository...                                                     
  [=========                              ] 25% Loading local repository...       
  [=========                              ] 25% Fetch remote repository...        
  [=======================================] 100% Fetch remote repository...       
  Error: Invalid --tag google_apis_ps16k for the selected package. Valid tags are:
  page_size_16kb

I'm on it

[mikehardy]

This thing just won't get fixed, sigh, now this PR is block

• fix: remove problematic / unneeded --abi option in avd creation ReactiveCircus/android-emulator-runner#456

[Haz3-jolt]

This thing just won't get fixed, sigh, now this PR is block

* [fix: remove problematic / unneeded `--abi` option in avd creation ReactiveCircus/android-emulator-runner#456](https://github.com/ReactiveCircus/android-emulator-runner/pull/456)

CI work being finicky as usual, I think another month or so till this is unblocked