Skip to content

fix(cdk/listbox): incorrect wording in error message #32697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crisbeto wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(cdk/listbox): incorrect wording in error message #32697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cdk/listbox/listbox.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ describe('CdkOption and CdkListbox', () => {
expect(() => {
testComponent.formControl.setValue(['orange', 'banana']);
fixture.detectChanges();
}).toThrowError('Listbox cannot have more than one selected value in multi-selection mode.');
}).toThrowError('Listbox cannot have more than one selected value in single selection mode.');
});

it('should throw when an invalid value is selected', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/cdk/listbox/listbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,7 +1018,7 @@ export class CdkListbox<T = unknown> implements AfterContentInit, OnDestroy, Con
const invalidValues = this._getInvalidOptionValues(selected);

if (!this.multiple && selected.length > 1) {
throw Error('Listbox cannot have more than one selected value in multi-selection mode.');
throw Error('Listbox cannot have more than one selected value in single selection mode.');
}

if (invalidValues.length) {
Expand Down
Loading