refactor(@angular/build): extract sourcemap adjustment logic in Vitest plugin #32370
+39
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t plugin This commit refactors the sourcemap source adjustment logic within the Vitest plugin into a standalone helper function, `adjustSourcemapSources`. This improves the readability of the `load` hook and isolates the logic for verifying and updating sourcemap paths. Additionally, the `map` parameter is now typed using `ExistingRawSourceMap` from `rolldown` instead of `any`.
clydin
added
the
action: review
…rove safety This commit improves the performance of the Vitest plugin by reusing a single `TextDecoder` instance for decoding memory files, avoiding repeated instantiation. It also adds safety checks when accessing the resolved Vitest configuration to prevent potential errors if the configuration is not yet fully initialized.
…itest plugin This commit removes a redundant code block in the `resolveId` hook of the Vitest plugin. The logic for resolving relative imports is fully covered by the subsequent generic path resolution strategy, reducing code duplication and complexity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the sourcemap source adjustment logic within the Vitest plugin into a standalone helper function,
adjustSourcemapSources. This improves the readability of theloadhook and isolates the logic for verifying and updating sourcemap paths.