fix(@angular/cli): enhance list_projects MCP tool file system traversal and symlink handling #32131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al and symlink handling This commit introduces several improvements to the `findAngularJsonFiles` function within the `list_projects` tool. An `isIgnorableFileError` helper was introduced to consistently handle file system errors (EACCES, EPERM, ENOENT, EBUSY) across `stat` and `readdir` calls, making the traversal more resilient to transient issues and unavailable directories. A check was implemented to ensure that symbolic links are only traversed if their resolved target paths are valid and remain within the defined search roots.
clydin
force-pushed
the
mcp/list-projects-symlinks
branch
from
061f145 to
19cdc76
Compare
alan-agius4
approved these changes
Dec 16, 2025
alan-agius4
added
action: merge
clydin
added
target: minor
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several improvements to the
findAngularJsonFilesfunction within thelist_projectstool. AnisIgnorableFileErrorhelper was introduced to consistently handle file system errors (EACCES, EPERM, ENOENT, EBUSY) acrossstatandreaddircalls, making the traversal more resilient to transient issues and unavailable directories. A check was implemented to ensure that symbolic links are only traversed if their resolved target paths are valid and remain within the defined search roots.