-
Notifications
You must be signed in to change notification settings - Fork 11.9k
Tailored error message for custom host #32056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/angular/build/src/tools/vite/middlewares/host-check-middleware.ts
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/middlewares/host-check-middleware.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/middlewares/host-check-middleware.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/middlewares/host-check-middleware.ts
Outdated
Show resolved
Hide resolved
03337ee to
2a4f460
Compare
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
Outdated
Show resolved
Hide resolved
packages/angular/build/src/builders/dev-server/tests/options/allowed-hosts_spec.ts
Outdated
Show resolved
Hide resolved
…tailored message New Blocked request page for custom host Fix angular#32028
2a4f460 to
af24a02
Compare
…ngular-tailored message
…ngular-tailored message
alan-agius4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
(pushed a cleanup commit)
…ngular-tailored message
…ngular-tailored message
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add custom middleware for to present an Angular-tailored message
Fix #32028
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The error message thrown when the Angular app is served via a custom hostname is incorrect/misleading
Issue Number: #32028
What is the new behavior?
Add custom middleware for to present an Angular-tailored message when angular served by ngrok
Does this PR introduce a breaking change?