Skip to content

Conversation

@aparzi
Copy link
Contributor

@aparzi aparzi commented Dec 6, 2025

Add custom middleware for to present an Angular-tailored message

Fix #32028

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The error message thrown when the Angular app is served via a custom hostname is incorrect/misleading

Issue Number: #32028

What is the new behavior?

Add custom middleware for to present an Angular-tailored message when angular served by ngrok

Does this PR introduce a breaking change?

  • Yes
  • No

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 8, 2025
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 9, 2025
@aparzi aparzi requested a review from alan-agius4 December 9, 2025 13:42
…tailored message

New Blocked request page for custom host

Fix angular#32028
@aparzi aparzi requested a review from alan-agius4 December 9, 2025 16:30
@alan-agius4 alan-agius4 removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 9, 2025
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

(pushed a cleanup commit)

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Dec 9, 2025
@hybrist hybrist merged commit 30b5d81 into angular:main Dec 10, 2025
34 checks passed
@hybrist
Copy link
Contributor

hybrist commented Dec 10, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serve Angular Application with ngrok

3 participants