refactor(@angular/cli): add generic package manifest resolver #31947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends the package manager abstraction to resolve manifests for various specifier types beyond registry packages. This is crucial for supporting packages installed from local directories, file archives, and git repositories. A new `getManifest` method is introduced on the `PackageManager` service. This method acts as a unified entry point for manifest resolution: - It uses `npm-package-arg` to parse the package specifier and determine its type (registry, directory, file, git, etc.). - For local directory specifiers, it reads the `package.json` directly from the filesystem for maximum efficiency. - For other non-registry specifiers (git repos, remote tarballs, local tarballs), it uses the `acquireTempPackage` flow to safely fetch and extract the package. - When acquiring a package, lifecycle scripts are disabled for improved security and performance. - To reliably determine the package name for non-registry types, the manifest resolver now inspects the temporary `package.json` after the package manager has installed the dependency. The existing `getPackageManifest` method has been renamed to `getRegistryManifest` to more accurately reflect its purpose.
clydin
added
the
action: review
alan-agius4
approved these changes
Nov 27, 2025
alan-agius4
added
action: merge
Collaborator
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the package manager abstraction to resolve manifests for various specifier types beyond registry packages. This is crucial for supporting packages installed from local directories, file archives, and git repositories.
A new
getManifestmethod is introduced on thePackageManagerservice. This method acts as a unified entry point for manifest resolution:npm-package-argto parse the package specifier and determine its type (registry, directory, file, git, etc.).package.jsondirectly from the filesystem for maximum efficiency.acquireTempPackageflow to safely fetch and extract the package.package.jsonafter the package manager has installed the dependency.The existing
getPackageManifestmethod has been renamed togetRegistryManifestto more accurately reflect its purpose.