Skip to content

fix(@angular/build): ensure external SSR middleware handles requests outside baseHref #31933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alessiopelliccione wants to merge 1 commit into from
Closed

fix(@angular/build): ensure external SSR middleware handles requests outside baseHref #31933

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions packages/angular/build/src/tools/vite/plugins/setup-middlewares-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,21 @@ export function createAngularSetupMiddlewaresPlugin(

extensionMiddleware?.forEach((middleware) => server.middlewares.use(middleware));

// For ExternalSsrMiddleware, install the middleware early to ensure custom middleware
// in server.ts can handle requests outside the base path (e.g., /ping when baseHref=/custom/)
// This allows fallthrough for custom routes that don't start with the configured baseHref
if (ssrMode === ServerSsrMode.ExternalSsrMiddleware) {
server.middlewares.use(
await createAngularSsrExternalMiddleware(server, indexHtmlTransformer),
);
}

// Returning a function, installs middleware after the main transform middleware but
// before the built-in HTML middleware
// eslint-disable-next-line @typescript-eslint/no-misused-promises
return async () => {
// ExternalSsrMiddleware was already installed above, skip here
if (ssrMode === ServerSsrMode.ExternalSsrMiddleware) {
server.middlewares.use(
await createAngularSsrExternalMiddleware(server, indexHtmlTransformer),
);

return;
}

Expand Down
Loading