fix(@schematics/angular): fix migration of jasmine.clock().mockDate()

[jnizet]

The migration previously migrated jasmine.clock().mockDate() to vi.setSystemTime(), which does not compile because vi.setSystemTime() requires an argument. This commit fixes it by migrating jasmine.clock().mockDate() to vi.setSystemTime(new Date()).

PR Checklist

Please check to confirm your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[atscott]

Should this be new Date(0) so you get a consistent base time?

[jnizet]

@atscott The documentation of Jasmine says that the default value is now.
So I chose to keep the same behavior in the migrated code.

[atscott]

Ah, yes. I guess any test which uses the default can’t actually depend on the date in any way except for how much time has passed (right?). Don’t know at that point if it’s better to do new Date(0) to signal that’s just a best practice to avoid an oopsie or to leave it as defaulting to now. Probably the latter I suppose if technically now could have been mocked beforehand.

[clydin]

This PR was merged into the repository. The changes were merged into the following branches:

• main: 32da5a8
• 21.0.x: 16d898e

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}