Skip to content

Conversation

@cexbrayat
Copy link
Member

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

When using ng g refactor-jasmine-vitest --add-imports the lifecycle hooks of vitest are not imported

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Nov 24, 2025

These functions are globally available.

@cexbrayat
Copy link
Member Author

If you don't use vitest globals, tests won't compile without importing them, so I think --add-imports should add them.

@cexbrayat cexbrayat force-pushed the fix/jasmine-vitest-imports branch from 9e7e7ee to 71e0e7a Compare November 24, 2025 13:09
@clydin clydin added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Nov 24, 2025
@clydin clydin merged commit 43d5dfa into angular:main Nov 24, 2025
36 checks passed
@clydin
Copy link
Member

clydin commented Nov 24, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants