Skip to content

Conversation

@clydin
Copy link
Member

@clydin clydin commented Nov 19, 2025

This commit fixes an issue in the Vitest browser setup where headless mode was not correctly configured on a per-browser-instance basis. Previously, the headless mode was applied globally, leading to incorrect behavior when mixing headed and headless browser names, or in specific environments.

Now, the configuration correctly:

  • Determines headless status from individual browser names (e.g., ChromeHeadless vs Chrome).
  • Forces all instances to be headless in CI environments.
  • Ensures the Preview provider forces instances to be headed.
  • Enables the UI only when running locally with at least one headed browser.

… Vitest runner

This commit fixes an issue in the Vitest browser setup where headless mode was not correctly configured
on a per-browser-instance basis. Previously, the headless mode was applied globally, leading to
incorrect behavior when mixing headed and headless browser names, or in specific environments.

Now, the configuration correctly:
- Determines headless status from individual browser names (e.g., `ChromeHeadless` vs `Chrome`).
- Forces all instances to be headless in CI environments.
- Ensures the Preview provider forces instances to be headed.
- Enables the UI only when running locally with at least one headed browser.
@clydin clydin force-pushed the unit-test/specific-headless branch from e562070 to 6b343f2 Compare November 19, 2025 19:06
@clydin clydin added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 19, 2025
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 20, 2025
@clydin clydin merged commit a71411f into angular:main Nov 20, 2025
34 checks passed
@clydin
Copy link
Member Author

clydin commented Nov 20, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@clydin clydin deleted the unit-test/specific-headless branch November 20, 2025 14:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular/build target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants