Skip to content

ci: add bun package manager to e2e tests #31856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dgp1130 merged 2 commits into from
Nov 19, 2025
Merged

ci: add bun package manager to e2e tests #31856

dgp1130 merged 2 commits into from
Nov 19, 2025

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Nov 18, 2025 •
edited
Loading

This commit introduces support for the bun package manager in our end-to-end tests.

The following changes are included:

  • The bun package manager is now part of the test matrix in the CI configuration.
  • The package manager flags for bun have been updated to align with the latest version.
  • The ng add command has been updated to support bun, including a workaround for a symlink issue.
  • Tests that are not compatible with bun, such as those for unscoped authentication, are now skipped when bun the active package manager.

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 18, 2025
@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release and removed area: build & ci Related the build and CI infrastructure of the project labels Nov 19, 2025
@alan-agius4 alan-agius4 changed the title ci: add bun to package manager suite ci: add bun package manager to e2e tests Nov 19, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Nov 19, 2025
@alan-agius4 alan-agius4 force-pushed the add-bun-e2e branch 4 times, most recently from d1ce56e to aaee6ab Compare November 19, 2025 11:23
@alan-agius4
ci: add bun package manager to e2e tests
6a8ce23 
This commit introduces support for the `bun` package manager in our end-to-end tests.

The following changes are included:
- The `bun` package manager is now part of the test matrix in the CI configuration.
- The package manager flags for `bun` have been updated to align with the latest version.
- The `ng add` command has been updated to support `bun`, including a workaround for a symlink issue.
- Tests that are not compatible with `bun`, such as those for unscoped authentication, are now skipped when `bun` the active package manager.
@alan-agius4 alan-agius4 requested a review from hybrist November 19, 2025 11:57
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 19, 2025
@alan-agius4 alan-agius4 marked this pull request as ready for review November 19, 2025 11:57
hybrist
hybrist approved these changes Nov 19, 2025
View reviewed changes
tests/legacy-cli/e2e/tests/commands/add/dir.ts
const collectionName = 'add-collection-dir';
const dirCollectionPath = resolve(collectionName);

// Copy locally as bun doesn't install the dependency correctly if it has symlinks.
Copy link
Contributor

@hybrist hybrist Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we report this to bun as well?

Copy link
Collaborator Author

@alan-agius4 alan-agius4 Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I’ll open an issue tomorrow

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker labels Nov 19, 2025
@ngbot
Copy link

ngbot bot commented Nov 19, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@dgp1130 dgp1130 merged commit 76ed178 into angular:main Nov 19, 2025
36 checks passed
@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 19, 2025

This PR was merged into the repository. The changes were merged into the following branches:

@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Dec 20, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@hybrist hybrist hybrist approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alan-agius4 @dgp1130 @hybrist