fix(@angular/build): enhance Vitest resolution for optimal package loading#31816
Merged
clydin merged 1 commit intoangular:mainfrom Nov 14, 2025
Merged
fix(@angular/build): enhance Vitest resolution for optimal package loading#31816clydin merged 1 commit intoangular:mainfrom
clydin merged 1 commit intoangular:mainfrom
Conversation
…ading Align Vitest's module resolution with the development server to ensure consistent behavior. This change configures Vitest to prioritize ESM-optimized package entry points by setting 'es2020', 'module', and 'main' as main fields and 'es2015', 'es2020', and 'module' as conditions during module resolution. This improves compatibility and performance by utilizing modern JavaScript module formats where available.
hybrist
approved these changes
Nov 14, 2025
hybrist
reviewed
Nov 14, 2025
| include: options.optimizeDepsInclude, | ||
| }, | ||
| resolve: { | ||
| mainFields: ['es2020', 'module', 'main'], |
Contributor
There was a problem hiding this comment.
Given that this contains some values that could change over time (e.g. es2020), can we decrease the risk of getting out of sync somehow?
Member
Author
There was a problem hiding this comment.
Those are there for older APF packages. We stopped using that in newer APF revisions. It's just default now with a single code variant.
Member
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align Vitest's module resolution with the development server to ensure consistent behavior. This change configures Vitest to prioritize ESM-optimized package entry points by setting 'es2020', 'module', and 'main' as main fields and 'es2015', 'es2020', and 'module' as conditions during module resolution. This improves compatibility and performance by utilizing modern JavaScript module formats where available.
Closes #31808