fix(@angular/build): enhance Vitest dependency externalization and pre-bundling#31781
Merged
clydin merged 1 commit intoangular:mainfrom Nov 13, 2025
Merged
Conversation
…e-bundling This commit refactors the dependency handling for the Vitest runner to improve flexibility and correctness, especially for browser-based tests. The previously hardcoded list of external Angular packages has been removed. Instead, a new `externalPackages: true` option is passed to the application builder, allowing for more dynamic and configurable externalization of packages. This prevents packages from `node_modules` from being bundled into the test entry points. Note: For cases where a dependency should not be pre-bundled, the `optimizeDeps.exclude` option can be used within a custom runner configuration file.
clydin
added
the
action: review
alan-agius4
approved these changes
Nov 13, 2025
alan-agius4
added
action: merge
Member
Author
13 tasks
yjaaidi
added a commit
to yjaaidi/angular-cli
that referenced
this pull request
Nov 13, 2025
Closes angular#31745 Actually closed by angular#31781
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit refactors the dependency handling for the Vitest runner to improve flexibility and correctness, especially for browser-based tests.
The previously hardcoded list of external Angular packages has been removed. Instead, a new
externalPackages: trueoption is passed to the application builder, allowing for more dynamic and configurable externalization of packages. This prevents packages fromnode_modulesfrom being bundled into the test entry points.Note: For cases where a dependency should not be pre-bundled, the
optimizeDeps.excludeoption can be used within a custom runner configuration file.