fix(@angular/build): enhance Vitest config merging and validation#31729
Merged
clydin merged 1 commit intoangular:mainfrom Nov 9, 2025
Merged
fix(@angular/build): enhance Vitest config merging and validation#31729clydin merged 1 commit intoangular:mainfrom
clydin merged 1 commit intoangular:mainfrom
Conversation
This change improves how user-defined Vitest configurations work with the Angular CLI's unit test builder. The builder now checks for and handles specific options in `vitest-base.config.ts`. It detects the `test.projects` option, logs a warning, and removes it to prevent conflicts. The `test.include` option is handled in a similar way, ensuring the builder's test discovery is used. Any `test.setupFiles` from `vitest-base.config.ts` are now added to the CLI's setup files, supporting both single string and array formats. User-defined Vite plugins from `vitest-base.config.ts` are also combined with the builder's plugins, with a filter to prevent duplicating internal CLI plugins. These updates give users more flexibility to customize their Vitest setup while keeping the Angular CLI's test builder predictable.
clydin
added
the
action: review
alan-agius4
approved these changes
Nov 9, 2025
alan-agius4
added
action: merge
Member
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves how user-defined Vitest configurations work with the Angular CLI's unit test builder.
The builder now checks for and handles specific options in
vitest-base.config.ts. It detects thetest.projectsoption, logs a warning, and removes it to prevent conflicts. Thetest.includeoption is handled in a similar way, ensuring the builder's test discovery is used. Anytest.setupFilesfromvitest-base.config.tsare now added to the CLI's setup files, supporting both single string and array formats. User-defined Vite plugins fromvitest-base.config.tsare also combined with the builder's plugins, with a filter to prevent duplicating internal CLI plugins.These updates give users more flexibility to customize their Vitest setup while keeping the Angular CLI's test builder predictable.