build: migrate license file handling to write_source_file#31725
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Nov 7, 2025
Merged
build: migrate license file handling to write_source_file#31725alan-agius4 merged 1 commit intoangular:mainfrom
write_source_file#31725alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
Migrate the handling of THIRD_PARTY_LICENSES.txt.golden in the SSR npm package from using `bazel_skylib`'s `diff_test` and `write_file` rules to `aspect_bazel_lib`'s `write_source_file` rule. This simplifies the Bazel configuration for managing the golden license file.
alan-agius4
added
action: review
angular-robot
bot
added
the
area: build & ci
alan-agius4
added
action: merge
hybrist
approved these changes
Nov 7, 2025
Collaborator
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the handling of
THIRD_PARTY_LICENSES.txt.goldenin the SSR npm package from usingbazel_skylib'sdiff_testandwrite_filerules toaspect_bazel_lib'swrite_source_filerule. This simplifies the Bazel configuration for managing the golden license file.