fix(@schematics/angular): add Vitest config generation and runner checks#31687
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Nov 4, 2025
Merged
fix(@schematics/angular): add Vitest config generation and runner checks#31687alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
This commit expands the `config` schematic to support generating a `vitest-base.config.ts` file and includes runner checks to prevent misconfiguration. Changes include: - Added 'vitest' as a valid type for the `config` schematic in `schema.json`. - Created a new `vitest-base.config.ts.template` file for generating a basic Vitest configuration. - Implemented the `addVitestConfig` function in `packages/schematics/angular/config/index.ts`: - Verifies that the project's `test` target uses the `@angular/build:unit-test` builder. - Copies the `vitest-base.config.ts` template to the project root. - Sets the `runnerConfig` option to `true` in `angular.json` to enable automatic discovery. - Includes warning logic to notify users if the `runner` option in `angular.json` is explicitly set to `karma`, indicating that the generated Vitest config may not be used.
clydin
added
the
action: review
alan-agius4
approved these changes
Nov 4, 2025
alan-agius4
added
action: merge
Collaborator
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit expands the
configschematic to support generating avitest-base.config.tsfile and includes runner checks to prevent misconfiguration.Changes include:
configschematic inschema.json.vitest-base.config.ts.templatefile for generating a basic Vitest configuration.addVitestConfigfunction inpackages/schematics/angular/config/index.ts:testtarget uses the@angular/build:unit-testbuilder.vitest-base.config.tstemplate to the project root.runnerConfigoption totrueinangular.jsonto enable automatic discovery.runneroption inangular.jsonis explicitly set tokarma, indicating that the generated Vitest config may not be used.