Conversation
dgp1130
left a comment
There was a problem hiding this comment.
Thanks for putting this together @amishne! Hopefully my comments should be internally consistent, but there might be a few which you addressed in later commits.
I know I left a lot of feedback, feel free to ack and ignore any comments you don't agree with or would rather follow up on separately from this PR. We definitely don't need to expand the scope any more than it already is.
I think probably my most important concern is just about whether we can reduce the dependency on specific log output and hopefully make this a little more durable to internal changes there.
packages/angular/cli/src/commands/mcp/tools/wait-for-devserver-build.ts
Outdated
Show resolved
Hide resolved
dgp1130
left a comment
There was a problem hiding this comment.
Don't forget to squash or switch to fixup! commits before merging, so "Address review comments" doesn't end up in our permanent history (it's fine for a PR, just don't want it being merged to main).
packages/angular/cli/src/commands/mcp/tools/wait-for-devserver-build.ts
Outdated
Show resolved
Hide resolved
New tools: * build * start_devserver * stop_devserver * wait_for_devserver_build See tool descriptions and MCP documentations for more.
|
This PR was merged into the repository. The changes were merged into the following branches:
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
New MCP experimental tools:
ng build.Notes: