fix(@angular/build): add define option to dev-server#31633
Merged
clydin merged 2 commits intoangular:mainfrom Oct 29, 2025
Merged
fix(@angular/build): add define option to dev-server#31633clydin merged 2 commits intoangular:mainfrom
define option to dev-server#31633clydin merged 2 commits intoangular:mainfrom
Conversation
alan-agius4
approved these changes
Oct 29, 2025
clydin
force-pushed
the
dev-server/define-passthrough
branch
from
ff9c806 to
cdaa818
Compare
This change introduces a `define` option to the dev-server builder, allowing users to specify global constants that will be replaced at build time. This provides a convenient way to configure environment-specific variables directly from the dev-server configuration. The dev-server `define` option is merged with any `define` options present in the underlying build target, with the dev-server's values taking precedence in case of conflicts. To support testing of this feature, a new `modifyTarget` method has been added to the builder test harness. This helper simplifies the modification of a target's options within a test case. Comprehensive end-to-end tests have been added to verify the replacement, merging, and override behaviors.
alan-agius4
force-pushed
the
dev-server/define-passthrough
branch
from
7a0f6a4 to
fd38f01
Compare
Member
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a
defineoption to the dev-server builder, allowing users to specify global constants that will be replaced at build time. This provides a convenient way to configure environment-specific variables directly from the dev-server configuration.The dev-server
defineoption is merged with anydefineoptions present in the underlying build target, with the dev-server's values taking precedence in case of conflicts.To support testing of this feature, a new
modifyTargetmethod has been added to the builder test harness. This helper simplifies the modification of a target's options within a test case. Comprehensive end-to-end tests have been added to verify the replacement, merging, and override behaviors.Closes #28905