fix(@schematics/angular): transform Jasmine type annotations in jasmine-to-vitest schematic#31567
Merged
clydin merged 1 commit intoangular:mainfrom Oct 23, 2025
Merged
Conversation
…ne-to-vitest schematic This commit enhances the jasmine-to-vitest refactoring schematic by adding support for transforming Jasmine's type annotations. Previously, the schematic only handled function calls, leaving type usages like `jasmine.SpyObj<T>` untouched and causing compilation errors in the transformed code. A new transformer now identifies and converts the following Jasmine types to their Vitest/TypeScript equivalents, preserving generics where appropriate: - `jasmine.Spy` -> `Mock` - `jasmine.SpyObj<T>` -> `MockedObject<T>` - `jasmine.ObjectContaining<T>` -> `Partial<T>` - `jasmine.ObjectContaining` -> `object` - `jasmine.Any` -> `any` - `jasmine.DoneFn` -> `() => void`
clydin
added
the
action: review
alan-agius4
approved these changes
Oct 23, 2025
alan-agius4
added
action: merge
clydin
added
target: major
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enhances the jasmine-to-vitest refactoring schematic by adding support for transforming Jasmine's type annotations. Previously, the schematic only handled function calls, leaving type usages like
jasmine.SpyObj<T>untouched and causing compilation errors in the transformed code.A new transformer now identifies and converts the following Jasmine types to their Vitest/TypeScript equivalents, preserving generics where appropriate:
jasmine.Spy->Mockjasmine.SpyObj<T>->MockedObject<T>jasmine.ObjectContaining<T>->Partial<T>jasmine.ObjectContaining->objectjasmine.Any->anyjasmine.DoneFn->() => void