Skip to content

build: remove shelljs usage#31541

Merged
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:shell-js
Oct 21, 2025
Merged

build: remove shelljs usage#31541
alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4:shell-js

Conversation

@alan-agius4
Copy link
Collaborator

The script goldens/public-api/manage.js is no longer functional due to the migration of the public API bazel tasks. This script was responsible for managing the public API golden files, but it is now obsolete.

As part of this change, the shelljs dependency has been replaced with native node:fs calls, and the associated npm scripts and documentation have been removed.

@alan-agius4 alan-agius4 requested a review from clydin October 21, 2025 09:10
@alan-agius4 alan-agius4 marked this pull request as ready for review October 21, 2025 09:10
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Oct 21, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Oct 21, 2025
@alan-agius4 alan-agius4 force-pushed the shell-js branch 2 times, most recently from 103f1c3 to 4408e3f Compare October 21, 2025 09:11
The script `goldens/public-api/manage.js` is no longer functional due to the removal of the public API bazel tasks. This script was responsible for managing the public API golden files, but it is now obsolete.

As part of this change, the `shelljs` dependency has been replaced with native `node:fs` calls, and the associated npm scripts and documentation have been removed.
@alan-agius4 alan-agius4 changed the title build: remove unused public-api management script build: remove shelljs usage Oct 21, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 21, 2025
@alan-agius4 alan-agius4 merged commit 0fa25de into angular:main Oct 21, 2025
30 checks passed
@alan-agius4 alan-agius4 deleted the shell-js branch October 21, 2025 13:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants