build: switch to @aspect_rules_jasmine for jasmine_test#31526
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Oct 20, 2025
Merged
build: switch to @aspect_rules_jasmine for jasmine_test#31526alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
The previous `jasmine_test` rule from `@devinfra//bazel/jasmine:jasmine.bzl` was causing `ENOENT` errors locally when running tests. This was likely due to issues with path handling and the `chdir` behavior. This change replaces the usage of `@devinfra//bazel/jasmine:jasmine.bzl` with `@aspect_rules_jasmine//jasmine:defs.bzl`. The `jasmine_test` macro in `tools/defaults.bzl` is updated to work with the new rule, including adjustments to argument passing and path handling to ensure tests can locate necessary modules like `source-map-support`. This resolves the local `ENOENT` error and aligns with a more standard way of running jasmine tests with bazel.
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
Oct 20, 2025
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
jasmine_testrule from@devinfra//bazel/jasmine:jasmine.bzlwas causingENOENTerrors locally when running tests. This was likely due to issues with path handling and thechdirbehavior.This change replaces the usage of
@devinfra//bazel/jasmine:jasmine.bzlwith@aspect_rules_jasmine//jasmine:defs.bzl. Thejasmine_testmacro intools/defaults.bzlis updated to work with the new rule, including adjustments to argument passing and path handling to ensure tests can locate necessary modules likesource-map-support.This resolves the local
ENOENTerror and aligns with a more standard way of running jasmine tests with bazel.