PostCSS error after Angular v21 and plugins relative to config file #1022
+12
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With proper project root path, the `loadPostcssConfiguration` function works as expected after the v21 update. Also, it's possible to simplify the `getTailwindConfig` implemntation, it will still build the correct relative path.
Collaborator
|
Seems fine to me! Thanks again for your time and efforts! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1021
In Angular CLI's v21.0.0 release, this commit was merge, which changes how the PostCSS plugins are located and loaded.
Because of that, and because the
projectRootwas justpath.dirname(tsConfigPath), an error happened when trying to find the TailwindCSS plugin.Angular has a
getProjectRootPaths(workspaceRoot, projectMetadata)utility function, but it's not exposed outside the lib. I was able to find inspiration here.With this approach, both
workspaceRootandprojectRootare absolute paths. Using withgenerateSearchDirectoriesmakes the PostCSS work and simplifies the TailwindCSS logic a bit, being able to drop manually having to create the path.Please feel free to comment.