Operator ergonomics#51
Merged
Merged
Conversation
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes table operators more ergonomic so:
content_folder_operator.torrent()log_create,log_updateandlog_deletemethodsThis requires the table operator to implement
Deref<Target = DatabaseOperator>andTableOperatorwhich has a single methodfn table(&self) -> Tableto save the table information in the logs.This PR also reduces allocations when switching tables because we don't have to clone the state/user every time, by introducing a lifetime for table operators. That means a table operator can only live as long as the inner DatabaseOperator, which is perfectly fine.