Apply custom lint all over modules#2106
Open
Jaehwa-Noh wants to merge 9 commits intoandroid:mainfrom
Open
Conversation
Change-Id: Ib26ae618bd132c438a4da2b72069a31469885587
Change-Id: I654a8663af53819d08cd3d7d82c839536904b1bb
Change-Id: I49b7e267ef15a3472c16f038769bdeb462da7381
Change-Id: I7d04a94a416d9b15226cdb3b83713a0d23c96bf2
Change-Id: I16de64865967524b3a0edb0fb1344d44ddbab3c1
Change-Id: I4b628b47fd20ad148cb5cd1f0ee9a178ea7473d0
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request restructures the linting module by moving rule implementations to a new :lint:impl subproject and updating module dependencies and documentation. The review feedback identifies that custom lint rules should be integrated using the lintChecks configuration rather than implementation to avoid unnecessary runtime overhead. Additionally, a package name inconsistency in the test suite needs to be corrected.
Change-Id: I5795fca2eeb2b1e9a82f4c6b1264de6a1c188c86
Change-Id: I90bdaf34b73c6769ca6faf25ac753feabc5ee909
Change-Id: Ic6b3265102e4012861eaad7901d84ac50a155a30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I have done and why
Custom lint is published under designsystem module and it checks with its dependencies.
But it makes some module missing the lint check.
Before
After
