Remove ComposableModifierFactory suppress lint#2026
Remove ComposableModifierFactory suppress lint#2026WonJoongLee wants to merge 1 commit intoandroid:mainfrom
Conversation
Summary of ChangesHello @WonJoongLee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on code hygiene by removing an outdated lint suppression. The Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly removes an obsolete @SuppressLint("ComposableModifierFactory") annotation and its associated comments. As you've noted in the description, this lint suppression is no longer necessary due to the updated recommendations for creating custom modifiers in Jetpack Compose. This is a good code cleanup that improves maintainability. The change looks good.
What I have done and why
I removed the
ComposableModifierFactorylint suppression because it no longer reports an error.This lint warning was removed after the official recommendation for custom modifiers changed.
Reference : Custom modifier documentation