Remove tracing from Espresso.onIdle.
#2451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
piper_832439638
branch
from
fa6a748 to
c66cd14
Compare
Espresso.onIdle can be called many times through the life of a test, creating memory issues for long running tests and providing questionable value. With this commit, the `Espresso.onIdle` method no longer creates a tracing span. Corresponding tests for the span are also removed. PiperOrigin-RevId: 833388360
copybara-service
bot
force-pushed
the
piper_832439638
branch
from
c66cd14 to
6c2d53d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove tracing from
Espresso.onIdle.Espresso.onIdle can be called many times through the life of a test,
creating memory issues for long running tests and providing questionable
value.
With this commit, the
Espresso.onIdlemethod no longer creates a tracing span. Corresponding tests for the span are also removed.