Nav3 migration#43
Open
chikoski wants to merge 5 commits intoandroid:jetstream-adaptive-composefrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request migrates the application's navigation system to Navigation3, involving significant refactoring of the app's structure, navigation components, and screen layouts. It also updates dependencies, including Gradle and Android SDK versions. I have identified a medium-severity issue regarding a production log statement that should be removed.
bsagmoe
requested changes
May 6, 2026
bsagmoe
left a comment
bsagmoe
left a comment
There was a problem hiding this comment.
General comment: each of the screens themselves should have an opaque background so that predictive back animations are less visually complex.
bsagmoe
requested changes
May 6, 2026
bsagmoe
left a comment
bsagmoe
left a comment
There was a problem hiding this comment.
One more general thing, using dropUnlessResumed to surround a handler that modifies the navigation state can also help prevent erroneous navigation:
StylableCard(
onClick = dropUnlessResumed { onClick() },
interactionSource = interactionSource,
content = image,
)
bsagmoe
reviewed
May 6, 2026
dturner
reviewed
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request migrates the navigation library to Navigation3.