Fix the issue caused by spaces in the username #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the safety and reliability of command-line argument handling for both Windows and WSL environments in the
src/extension.tsfile. The main focus is on escaping arguments to prevent issues with spaces and special characters when spawning processes or sending commands to terminals. Two utility functions are introduced for escaping arguments in Windows (escapeShellArg) and bash/WSL (escapeBashArg), and these are now used throughout the code wherever commands are constructed.Argument escaping and process spawning:
escapeShellArgandescapeBashArgutility functions to safely handle command-line arguments for Windows and bash/WSL shells, preventing errors due to spaces or special characters.escapeBashArgfor all relevant arguments, ensuring commands are correctly quoted and parsed in bash.escapeShellArgfor arguments whenshell: trueis set, improving compatibility and correctness.Terminal command construction:
escapeBashArgfor paths and arguments, ensuring robust handling of spaces and special characters. [1] [2] [3]