adjust file heirarchy to use cmd/allmark#38
Open
urandom2 wants to merge 2 commits intoandreaskoch:developfrom
Open
adjust file heirarchy to use cmd/allmark#38urandom2 wants to merge 2 commits intoandreaskoch:developfrom
urandom2 wants to merge 2 commits intoandreaskoch:developfrom
Conversation
This is a minimum viable change to enable modern go toolchains to build github.com/andreaskoch/allmark/cli in go module mode. The module is not tidy, and we are relying on ./vendor, but it does build.
The use of the cli directory works, but makes go-get painful to use. This change adopts the standard cmd directory for main packages, and allows for go get github.com/andreaskoch/allmark/cmd/allmark. Note this is a breaking change, as go get github.com/andreaskoch/allmark/cli will not do what it did before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of the cli directory works, but makes go-get painful to use.
This change adopts the standard cmd directory for main packages, and
allows for go get github.com/andreaskoch/allmark/cmd/allmark.
Note this is a breaking change, as go get
github.com/andreaskoch/allmark/cli will not do what it did before.