Skip to content

add ability to spoof MacOS and Windows#1

Open
dshaps10 wants to merge 9 commits into
andreas-optimizely:masterfrom
dshaps10:master
Open

add ability to spoof MacOS and Windows#1
dshaps10 wants to merge 9 commits into
andreas-optimizely:masterfrom
dshaps10:master

Conversation

@dshaps10
Copy link
Copy Markdown

Hey Andreas,

I Added to the existing extension and changed up a bit of the logic to account for multiple user-agents. Here's a summary of the changes:

  1. Add multiple user-agents to userAgents object and include a field for img urls
  2. Add conditional logic to choose which icon to display and whether to set the status to active
  3. Update static user-agent value to be dynamic
  4. track user clicks

The main way I changed it is that a customer can change which user-agent they want to spoof based on the number of times they click the icon. If they click 4 times, they disable to extension.

I ran the code through Gulp and everything seems to check out but there may still be some corrections that need to be made.

@andreas-optimizely
Copy link
Copy Markdown
Owner

@dshaps10 thanks for this! Were you able to do some QA on this and verify it all works after getting compiled by Gulp?

@dshaps10
Copy link
Copy Markdown
Author

I was actually having a little bit of trouble with that. It took forever to
upload it to chrome.

On Wed, Nov 16, 2016, 12:32 PM Andreas Bloomquist notifications@github.com
wrote:

@dshaps10 https://github.com/dshaps10 thanks for this! Were you able to
do some QA on this and verify it all works after getting compiled by Gulp?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APihExCVXX6_0jqNklPjXX9O8r9mEUfVks5q-z4HgaJpZM4K0Ghm
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants