add ability to spoof MacOS and Windows#1
Open
dshaps10 wants to merge 9 commits into
Open
Conversation
Owner
|
@dshaps10 thanks for this! Were you able to do some QA on this and verify it all works after getting compiled by Gulp? |
Author
|
I was actually having a little bit of trouble with that. It took forever to On Wed, Nov 16, 2016, 12:32 PM Andreas Bloomquist notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Andreas,
I Added to the existing extension and changed up a bit of the logic to account for multiple user-agents. Here's a summary of the changes:
The main way I changed it is that a customer can change which user-agent they want to spoof based on the number of times they click the icon. If they click 4 times, they disable to extension.
I ran the code through Gulp and everything seems to check out but there may still be some corrections that need to be made.