[WIP] No mappable #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For now, the old api was completly removed, so this is an breaking change. * Uses the standard on dart to call toJson to convert objects, allowing the usage of codegen packages on the states and events. * Also tries to simplify the logic a little bit. * Update lower sdk constraint to 2.3.0 because of collection 'if' operator
* Remove 'implements Mappable' on the affected classes. * Modify from '@OverRide Map<String, dynamic> toMap()' to 'Map<String, dynamic> toJson()'.
* The jsonOrNull will be null and the actionName will be the passed action String.
Owner
|
Good job @KalilDev, thank you for contribution!! I think we need to add |
Author
|
Alright, totally agree! Im sorry, i was a bit busy this week and could not do it. Im going on a trip and when i come back, in the 28th, i will continue the work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the logic a bit, got rid of Mappable, implemented the toJson replacement and migrated the example packages. I've yet to add tests, and i want to know what you think.